Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 438443004: Revert of Add ETC1 format to SkTextureCompressor (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add ETC1 format to SkTextureCompressor (https://codereview.chromium.org/432143002/) Reason for revert: Breaking Chrome. Original issue's description: > Add ETC1 format to SkTextureCompressor > > Committed: https://skia.googlesource.com/skia/+/5d8b1b44ea7636fc8e98247cb311568f277ce3a5 TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/50495571df39ac3300c113ae5b0f607a8d7e59da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -60 lines) Patch
M gyp/utils.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/images/SkImageDecoder_pkm.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 2 chunks +8 lines, -13 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 5 chunks +2 lines, -35 lines 0 comments Download
M tests/TextureCompressionTest.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
krajcevski
Created Revert of Add ETC1 format to SkTextureCompressor
6 years, 4 months ago (2014-08-04 16:46:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/438443004/1
6 years, 4 months ago (2014-08-04 16:47:24 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 16:47:35 UTC) #3
Message was sent while issue was closed.
Change committed as 50495571df39ac3300c113ae5b0f607a8d7e59da

Powered by Google App Engine
This is Rietveld 408576698