Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 438373002: PictureLayerImplTests: Start frame time ticks at 1 millisecond. (Closed)

Created:
6 years, 4 months ago by hush (inactive)
Modified:
6 years, 4 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

LTHI does not treat 0 as a valid time tick, instead it will use gfx::FrameTime::Now(). Start frame time ticks at 1 millisecond so that LTHI does not use gfx::FrameTime::Now(). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287641

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M cc/layers/picture_layer_impl_unittest.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hush (inactive)
I didn't increase the time ticks after SetupDrawPropertiesAndUpdateTiles() for those tests, but the tests still ...
6 years, 4 months ago (2014-08-05 19:36:51 UTC) #1
aelias_OOO_until_Jul13
lgtm, thanks for the cleanup.
6 years, 4 months ago (2014-08-05 20:19:00 UTC) #2
hush (inactive)
The CQ bit was checked by hush@chromium.org
6 years, 4 months ago (2014-08-05 20:37:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hush@chromium.org/438373002/1
6 years, 4 months ago (2014-08-05 20:38:10 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 23:32:42 UTC) #5
Message was sent while issue was closed.
Change committed as 287641

Powered by Google App Engine
This is Rietveld 408576698