Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issue 438303003: Removed GetConstructor from the API (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Project:
v8
Visibility:
Public.

Description

Removed GetConstructor from the API. Instead either get the "constructor" property stored in the prototype, or keep a side-table. LOG=y R=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M include/v8.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-08-05 11:20:30 UTC) #1
jochen (gone - plz use gerrit)
lgtm.
6 years, 4 months ago (2014-08-05 11:27:03 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-05 11:27:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 22861 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698