Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1618)

Unified Diff: Source/platform/audio/AudioDSPKernel.h

Issue 438293003: Enable Oilpan by default for webaudio/ (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/audio/AudioDSPKernel.h
diff --git a/Source/platform/audio/AudioDSPKernel.h b/Source/platform/audio/AudioDSPKernel.h
index a006864acd585a3962c8af5870099bfe3043c3d0..9ecb12a58b1a0d8b59856ddef59c42af910c0721 100644
--- a/Source/platform/audio/AudioDSPKernel.h
+++ b/Source/platform/audio/AudioDSPKernel.h
@@ -67,6 +67,13 @@ public:
virtual double latencyTime() const = 0;
protected:
+ // Oilpan: This raw pointer is safe because the AudioDSPKernelProcessor
+ // object is guaranteed to be kept alive while the AudioDSPKernel object
+ // is alive. Ideally we want to move the AudioDSPKernel hierarchy to
+ // the heap and use a Member<AudioDSPKernelProcessor>. However, we cannot
+ // do that because AudioDSPKernel can be allocated in audio threads
+ // (which are not registered to Oilpan).
+ GC_PLUGIN_IGNORE("")
tkent 2014/08/18 08:54:51 Bug URL?
haraken 2014/08/18 09:11:02 Filed issue 404578 and added the bug number here.
AudioDSPKernelProcessor* m_kernelProcessor;
float m_sampleRate;
};

Powered by Google App Engine
This is Rietveld 408576698