Sanitize referrer in context menus.

Sanitize referrer in context menus.

This CL adds a method to content::Referrer that allows for sanitizing the referrer before making a network request and uses it to scrub the Referer header for requests originating in the context menu.
It is based on work started by cbentzel@ in https://codereview.chromium.org/277903002/.

BUG=357473
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287579

[nasko, 2014-08-05 12:01:52]

Hey Jochen,
Can you take a look at this CL? I've ported over Chris' sanitizer method and
used it in the context menu code.
Thanks!
Nasko

[jochen (gone - plz use gerrit), 2014-08-05 13:27:42]

https://codereview.chromium.org/438283002/diff/60001/content/public/common/re...
File content/public/common/referrer.h (right):

https://codereview.chromium.org/438283002/diff/60001/content/public/common/re...
content/public/common/referrer.h:32: sanitized_referrer.policy =
referrer.policy;
can you also make SerializedNavigationEntry::Sanitize use this method (in
components/sessions/serialized_navigation_entry.cc)

esp, we should clear the referrer if either the referrer or the request url are
not in the http family.

[nasko, 2014-08-05 14:27:58]

https://codereview.chromium.org/438283002/diff/60001/content/public/common/re...
File content/public/common/referrer.h (right):

https://codereview.chromium.org/438283002/diff/60001/content/public/common/re...
content/public/common/referrer.h:32: sanitized_referrer.policy =
referrer.policy;
On 2014/08/05 13:27:42, jochen wrote:
> can you also make SerializedNavigationEntry::Sanitize use this method (in
> components/sessions/serialized_navigation_entry.cc)
> 
> esp, we should clear the referrer if either the referrer or the request url
are
> not in the http family.

Done.

https://codereview.chromium.org/438283002/diff/2/components/sessions/serializ...
File components/sessions/serialized_navigation_entry.cc (right):

https://codereview.chromium.org/438283002/diff/2/components/sessions/serializ...
components/sessions/serialized_navigation_entry.cc:522: referrer_ =
content::Referrer();
Should this be totally cleared or should the sanitized version be kept?

[jochen (gone - plz use gerrit), 2014-08-05 15:16:56]

lgtm

https://codereview.chromium.org/438283002/diff/2/components/sessions/serializ...
File components/sessions/serialized_navigation_entry.cc (right):

https://codereview.chromium.org/438283002/diff/2/components/sessions/serializ...
components/sessions/serialized_navigation_entry.cc:522: referrer_ =
content::Referrer();
here totally clearing is fine.

[nasko, 2014-08-05 15:32:20]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2014-08-05 15:33:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nasko@chromium.org/438283002/2

[commit-bot: I haz the power, 2014-08-05 17:15:47]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-05 17:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 17:57:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nasko, 2014-08-05 19:06:29]

The CQ bit was checked by nasko@chromium.org

[commit-bot: I haz the power, 2014-08-05 19:07:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nasko@chromium.org/438283002/2

[commit-bot: I haz the power, 2014-08-05 19:47:04]

Change committed as 287579