Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 438273002: DevTools: introduce ViewportDataGrid (Closed)

Created:
6 years, 4 months ago by eustas
Modified:
6 years, 4 months ago
Reviewers:
vsevik, alph, lushnikov, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

DevTools: introduce ViewportDataGrid BUG=316092 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179951

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Total comments: 28

Patch Set 4 : #

Patch Set 5 : #

Total comments: 6

Patch Set 6 : #

Total comments: 2

Patch Set 7 : #

Patch Set 8 : rebase #

Patch Set 9 : #

Patch Set 10 : inline mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -57 lines) Patch
M Source/devtools/devtools.gypi View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M Source/devtools/front_end/ui/DataGrid.js View 1 2 3 4 5 6 7 2 chunks +11 lines, -6 lines 0 comments Download
M Source/devtools/front_end/ui/SortableDataGrid.js View 3 chunks +12 lines, -48 lines 0 comments Download
A Source/devtools/front_end/ui/ViewportDataGrid.js View 1 2 3 4 5 6 7 8 9 1 chunk +222 lines, -0 lines 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (0 generated)
lushnikov
https://codereview.chromium.org/438273002/diff/1/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/438273002/diff/1/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode60 Source/devtools/front_end/ui/ViewportDataGrid.js:60: if (y + h >= top) { let's simplify ...
6 years, 4 months ago (2014-08-05 11:46:34 UTC) #1
yurys
Can we extract existing implementation of view port from heap profiler code instead of introducing ...
6 years, 4 months ago (2014-08-05 11:54:03 UTC) #2
eustas
https://codereview.chromium.org/438273002/diff/1/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/438273002/diff/1/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode60 Source/devtools/front_end/ui/ViewportDataGrid.js:60: if (y + h >= top) { On 2014/08/05 ...
6 years, 4 months ago (2014-08-06 11:39:12 UTC) #3
lushnikov
lgtm https://codereview.chromium.org/438273002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/438273002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode17 Source/devtools/front_end/ui/ViewportDataGrid.js:17: this._scrollContainer.addEventListener("scroll", this._onScroll.bind(this), true); how do we react on ...
6 years, 4 months ago (2014-08-06 16:57:34 UTC) #4
lushnikov
lgtm
6 years, 4 months ago (2014-08-06 16:57:46 UTC) #5
lushnikov
Also, we will have to add kinetic scroll here - it doesn't work by default ...
6 years, 4 months ago (2014-08-06 17:10:58 UTC) #6
eustas
https://codereview.chromium.org/438273002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/438273002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode17 Source/devtools/front_end/ui/ViewportDataGrid.js:17: this._scrollContainer.addEventListener("scroll", this._onScroll.bind(this), true); On 2014/08/06 16:57:32, lushnikov wrote: > ...
6 years, 4 months ago (2014-08-08 09:59:45 UTC) #7
eustas
https://codereview.chromium.org/438273002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/438273002/diff/40001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode97 Source/devtools/front_end/ui/ViewportDataGrid.js:97: if (currentNode._stale) On 2014/08/06 16:57:33, lushnikov wrote: > would ...
6 years, 4 months ago (2014-08-08 10:00:13 UTC) #8
vsevik
https://chromiumcodereview.appspot.com/438273002/diff/80001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://chromiumcodereview.appspot.com/438273002/diff/80001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode87 Source/devtools/front_end/ui/ViewportDataGrid.js:87: visibleNodes[i].__willBeAttached = true; Please use Set instead. https://chromiumcodereview.appspot.com/438273002/diff/80001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode103 Source/devtools/front_end/ui/ViewportDataGrid.js:103: ...
6 years, 4 months ago (2014-08-11 07:39:08 UTC) #9
vsevik
And what about the kinetic scroll mentioned above?
6 years, 4 months ago (2014-08-11 07:39:26 UTC) #10
eustas
https://chromiumcodereview.appspot.com/438273002/diff/80001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://chromiumcodereview.appspot.com/438273002/diff/80001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode87 Source/devtools/front_end/ui/ViewportDataGrid.js:87: visibleNodes[i].__willBeAttached = true; On 2014/08/11 07:39:08, vsevik wrote: > ...
6 years, 4 months ago (2014-08-11 08:43:58 UTC) #11
eustas
On 2014/08/11 07:39:26, vsevik wrote: > And what about the kinetic scroll mentioned above? Andrey ...
6 years, 4 months ago (2014-08-11 08:46:29 UTC) #12
vsevik
lgtm https://chromiumcodereview.appspot.com/438273002/diff/100001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://chromiumcodereview.appspot.com/438273002/diff/100001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode100 Source/devtools/front_end/ui/ViewportDataGrid.js:100: tBody.insertBefore(nodeElement, previousNode.nextSibling); previousElement
6 years, 4 months ago (2014-08-11 09:17:48 UTC) #13
eustas
https://codereview.chromium.org/438273002/diff/100001/Source/devtools/front_end/ui/ViewportDataGrid.js File Source/devtools/front_end/ui/ViewportDataGrid.js (right): https://codereview.chromium.org/438273002/diff/100001/Source/devtools/front_end/ui/ViewportDataGrid.js#newcode100 Source/devtools/front_end/ui/ViewportDataGrid.js:100: tBody.insertBefore(nodeElement, previousNode.nextSibling); On 2014/08/11 09:17:48, vsevik wrote: > previousElement ...
6 years, 4 months ago (2014-08-11 09:24:04 UTC) #14
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-11 09:24:11 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/438273002/120001
6 years, 4 months ago (2014-08-11 09:24:57 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-11 09:44:15 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 09:45:15 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/15769) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/39898)
6 years, 4 months ago (2014-08-11 09:45:16 UTC) #19
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-11 10:14:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/438273002/160001
6 years, 4 months ago (2014-08-11 10:15:08 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-11 11:28:23 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-11 11:59:00 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/20009)
6 years, 4 months ago (2014-08-11 11:59:01 UTC) #24
eustas
The CQ bit was checked by eustas@chromium.org
6 years, 4 months ago (2014-08-11 13:22:35 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eustas@chromium.org/438273002/180001
6 years, 4 months ago (2014-08-11 13:23:32 UTC) #26
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 14:22:17 UTC) #27
Message was sent while issue was closed. 
Change committed as 179951

Powered by Google App Engine
This is Rietveld 408576698