Issue 438243003: Revert "Initial import of unittests using GTest/GMock."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438243003: Revert "Initial import of unittests using GTest/GMock." (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Initial import of unittests using GTest/GMock." This reverts commit r22847 and r22848. Isolate initialization/shutdown still broken (so certain debug builds just crash), and our compiler flags do not work with other Google projects (i.e. GTest/GMock). TBR=jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22855

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -528 lines)			Patch
M	build/all.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	test/unittests/DEPS	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	test/unittests/compiler/arm/test-instruction-selector-arm.cc	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	test/unittests/compiler/test-instruction-selector.h	View	1 chunk	+0 lines, -88 lines	0 comments	Download
D	test/unittests/compiler/test-instruction-selector.cc	View	1 chunk	+0 lines, -78 lines	0 comments	Download
D	test/unittests/test-isolate.h	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	test/unittests/test-isolate.cc	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	test/unittests/test-zone.h	View	1 chunk	+0 lines, -29 lines	0 comments	Download
D	test/unittests/test-zone.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	test/unittests/testcfg.py	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	test/unittests/unittests.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	test/unittests/unittests.cc	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	test/unittests/unittests.gyp	View	1 chunk	+0 lines, -54 lines	0 comments	Download
D	test/unittests/unittests.status	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	testing/gtest.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/presubmit.py	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/run-tests.py	View	1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 4 months ago (2014-08-05 10:16:58 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as 22855 (tree was closed).

Expand Messages | Collapse Messages