Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 438193003: Updating MakeMenuItemStringsFor() to include custom items if provided by blink. (Closed)

Created:
6 years, 4 months ago by pals
Modified:
6 years, 4 months ago
Reviewers:
tkent, Dirk Pranke
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updating MakeMenuItemStringsFor() to include custom items if provided by blink. BUG=87553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287527

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added submenu and menu depth identifier #

Total comments: 14

Patch Set 3 : Fixed #

Total comments: 8

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M content/shell/renderer/test_runner/event_sender.cc View 1 2 3 4 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pals
This will be used for layout testing custom context menu https://codereview.chromium.org/243403006/. PTAL.
6 years, 4 months ago (2014-08-05 06:20:31 UTC) #1
tkent
https://codereview.chromium.org/438193003/diff/1/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/1/content/shell/renderer/test_runner/event_sender.cc#newcode136 content/shell/renderer/test_runner/event_sender.cc:136: PopulateCustomItems(customItems[i].subMenuItems, strings); Let's prepend/append something to items for submenus. ...
6 years, 4 months ago (2014-08-05 06:36:57 UTC) #2
pals
Added submenu and menu depth identifier as suggested. https://codereview.chromium.org/438193003/diff/1/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/1/content/shell/renderer/test_runner/event_sender.cc#newcode136 content/shell/renderer/test_runner/event_sender.cc:136: PopulateCustomItems(customItems[i].subMenuItems, ...
6 years, 4 months ago (2014-08-05 08:38:09 UTC) #3
tkent
https://codereview.chromium.org/438193003/diff/20001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/20001/content/shell/renderer/test_runner/event_sender.cc#newcode125 content/shell/renderer/test_runner/event_sender.cc:125: const std::string kSubMenuIdentifier = " >"; We don't allow ...
6 years, 4 months ago (2014-08-05 08:50:11 UTC) #4
pals
Updated the patch. PTAL. https://codereview.chromium.org/438193003/diff/20001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/20001/content/shell/renderer/test_runner/event_sender.cc#newcode125 content/shell/renderer/test_runner/event_sender.cc:125: const std::string kSubMenuIdentifier = " ...
6 years, 4 months ago (2014-08-05 09:02:25 UTC) #5
tkent
https://codereview.chromium.org/438193003/diff/40001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/40001/content/shell/renderer/test_runner/event_sender.cc#newcode133 content/shell/renderer/test_runner/event_sender.cc:133: void PopulateCustomItems(const WebVector<WebMenuItemInfo>& customItems, This doesn't follow Chromium coding ...
6 years, 4 months ago (2014-08-05 09:08:45 UTC) #6
pals
Please take a look. https://codereview.chromium.org/438193003/diff/40001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/40001/content/shell/renderer/test_runner/event_sender.cc#newcode133 content/shell/renderer/test_runner/event_sender.cc:133: void PopulateCustomItems(const WebVector<WebMenuItemInfo>& customItems, On ...
6 years, 4 months ago (2014-08-05 09:17:29 UTC) #7
tkent
lgtm https://codereview.chromium.org/438193003/diff/60001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/60001/content/shell/renderer/test_runner/event_sender.cc#newcode192 content/shell/renderer/test_runner/event_sender.cc:192: // Populate custom menu items if provided by ...
6 years, 4 months ago (2014-08-05 09:18:40 UTC) #8
pals
https://codereview.chromium.org/438193003/diff/60001/content/shell/renderer/test_runner/event_sender.cc File content/shell/renderer/test_runner/event_sender.cc (right): https://codereview.chromium.org/438193003/diff/60001/content/shell/renderer/test_runner/event_sender.cc#newcode192 content/shell/renderer/test_runner/event_sender.cc:192: // Populate custom menu items if provided by the ...
6 years, 4 months ago (2014-08-05 09:20:36 UTC) #9
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-05 10:07:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/438193003/80001
6 years, 4 months ago (2014-08-05 10:08:44 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 13:10:25 UTC) #12
Message was sent while issue was closed.
Change committed as 287527

Powered by Google App Engine
This is Rietveld 408576698