Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 438173004: Add a UseCounter for SVGStyleElement.title. (Closed)

Created:
6 years, 4 months ago by Erik Dahlström (inactive)
Modified:
6 years, 4 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, krit, arv+blink, fs, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for SVGStyleElement.title. BUG=399271 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGStyleElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Erik Dahlström (inactive)
6 years, 4 months ago (2014-08-05 14:12:15 UTC) #1
Stephen Chennney
LGTM. Once this lands there's another update necessary in the histogram code at src/tools/metrics/histograms/histograms.xml Looks ...
6 years, 4 months ago (2014-08-05 14:25:05 UTC) #2
Stephen Chennney
The CQ bit was checked by schenney@chromium.org
6 years, 4 months ago (2014-08-05 14:26:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/438173004/1
6 years, 4 months ago (2014-08-05 14:27:07 UTC) #4
Erik Dahlström (inactive)
On 2014/08/05 14:25:05, Stephen Chenney wrote: > LGTM. Once this lands there's another update necessary ...
6 years, 4 months ago (2014-08-05 14:28:05 UTC) #5
Stephen Chennney
On 2014/08/05 14:28:05, Erik Dahlström wrote: > On 2014/08/05 14:25:05, Stephen Chenney wrote: > > ...
6 years, 4 months ago (2014-08-05 14:29:35 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-05 18:53:01 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 21:12:05 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/19720)
6 years, 4 months ago (2014-08-05 21:12:06 UTC) #9
Erik Dahlström (inactive)
The CQ bit was checked by ed@opera.com
6 years, 4 months ago (2014-08-06 07:45:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/438173004/1
6 years, 4 months ago (2014-08-06 07:45:42 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 07:51:01 UTC) #12
Message was sent while issue was closed.
Change committed as 179575

Powered by Google App Engine
This is Rietveld 408576698