Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 438163004: Fix inverted early return check in variations simulation code. (Closed)

Created:
6 years, 4 months ago by Alexei Svitkine (slow)
Modified:
6 years, 4 months ago
Reviewers:
jwd
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix inverted early return check in variations simulation code. BUG=394855 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/metrics/variations/variations_service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexei Svitkine (slow)
6 years, 4 months ago (2014-08-05 14:45:11 UTC) #1
jwd
lgtm
6 years, 4 months ago (2014-08-05 19:15:28 UTC) #2
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-05 19:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/438163004/1
6 years, 4 months ago (2014-08-05 19:23:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 22:37:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 00:13:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42902)
6 years, 4 months ago (2014-08-06 00:13:18 UTC) #7
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 4 months ago (2014-08-06 03:54:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/438163004/1
6 years, 4 months ago (2014-08-06 03:57:05 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 05:59:22 UTC) #10
Message was sent while issue was closed. 
Change committed as 287694

Powered by Google App Engine
This is Rietveld 408576698