Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 438113002: Merge 286589 "Do not save and restore View focus on aura::Window..." (Closed)

Created:
6 years, 4 months ago by msw
Modified:
6 years, 4 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Project:
chromium
Visibility:
Public.

Description

Merge 286589 "Do not save and restore View focus on aura::Window..." > Do not save and restore View focus on aura::Window focus changes. > > My http://crrev.com/271312 was wrong; see http://crbug.com/391376#c16 > > This resolves the following defects: > 1) 394661 - print preview focus is restored on tab switch. > 2) 391376 - print preview gets focused from CrOS photo editor. > 3) 398766 - saving and restoring focus on bubbles/dialogs. > > This reintroduces the following defects fixed by r271312: > 1) 368691 - can't re-type in omnibox after focusing print preview > 2) omnibox retains focus when re-focusing print preview. > (shows selection/cursor and leaves dropdown window open) > > TODO(msw): Fix 368691 again... (web dialog focus issue) > > BUG=391376, 394661, 398766, 368691 > TEST=Issues 391376, 394661, and 398766 are fixed; 368691 regresses (for now). > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/418093005 TBR=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
msw
6 years, 4 months ago (2014-08-04 19:17:06 UTC) #1
msw
6 years, 4 months ago (2014-08-04 19:20:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r287389 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698