Issue 438103002: Fix Object-getOwnPropertyNames test after turning on Symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 438103002: Fix Object-getOwnPropertyNames test after turning on Symbols (Closed)

Created:
6 years, 4 months ago by adamk

Modified:
6 years, 4 months ago

Reviewers:
Dmitry Lomov (no reviews), arv (Not doing code reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix Object-getOwnPropertyNames test after turning on Symbols TBR=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22833

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	test/webkit/fast/js/Object-getOwnPropertyNames.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

Why don't we update the test so that it does not have an incorrect expectation?

6 years, 4 months ago (2014-08-04 19:17:01 UTC) #2

adamk

6 years, 4 months ago (2014-08-04 19:17:54 UTC) #3

Message was sent while issue was closed.

On 2014/08/04 at 19:17:01, arv wrote:
> Why don't we update the test so that it does not have an incorrect
expectation?

That is a good question, but one I want to handle separately. (There a bunch of
FAIL lines elsewhere in this test).

Expand Messages | Collapse Messages