Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 438053002: Don't compare coord change matrices to determine effect compatibility when using explicit local coo… (Closed)

Created:
6 years, 4 months ago by bsalomon
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@nomat
Visibility:
Public.

Description

Don't compare coord change matrices to determine effect compatibility when using explicit local coords. Committed: https://skia.googlesource.com/skia/+/0673676854da8051eb97515b601eb425b079e103

Patch Set 1 #

Patch Set 2 : whitespace' #

Total comments: 2

Patch Set 3 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -14 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M include/gpu/GrEffectStage.h View 1 2 1 chunk +15 lines, -10 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
This allows the fishies to batch.
6 years, 4 months ago (2014-08-04 16:05:15 UTC) #1
robertphillips
lgtm + comment suggestion https://codereview.chromium.org/438053002/diff/20001/include/gpu/GrEffectStage.h File include/gpu/GrEffectStage.h (right): https://codereview.chromium.org/438053002/diff/20001/include/gpu/GrEffectStage.h#newcode52 include/gpu/GrEffectStage.h:52: // When explicit local coordinates ...
6 years, 4 months ago (2014-08-04 16:08:46 UTC) #2
bsalomon
https://codereview.chromium.org/438053002/diff/20001/include/gpu/GrEffectStage.h File include/gpu/GrEffectStage.h (right): https://codereview.chromium.org/438053002/diff/20001/include/gpu/GrEffectStage.h#newcode52 include/gpu/GrEffectStage.h:52: On 2014/08/04 16:08:46, robertphillips wrote: > // When explicit ...
6 years, 4 months ago (2014-08-04 16:12:33 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 4 months ago (2014-08-04 17:45:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/438053002/40001
6 years, 4 months ago (2014-08-04 17:45:47 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 17:56:49 UTC) #6
Message was sent while issue was closed. 
Change committed as 0673676854da8051eb97515b601eb425b079e103

Powered by Google App Engine
This is Rietveld 408576698