Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 438043003: Disable TraceOptionsTest.TraceOptionsFromString (Correction) (Closed)

Created:
6 years, 4 months ago by robliao
Modified:
6 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, wfh+watch_chromium.org, dsinclair+watch_chromium.org, erikwright+watch_chromium.org, Adam Rice, dgreid, Adrian Kuegel
Project:
chromium
Visibility:
Public.

Description

Disable TraceOptionsTest.TraceOptionsFromString This test breaks on iOS Simulation. Introduced by https://codereview.chromium.org/425593002 BUG=400382 TBR=nednguyen Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287361 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287362

Patch Set 1 #

Patch Set 2 : Disable Correct Test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/debug/trace_event_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robliao
6 years, 4 months ago (2014-08-04 17:57:24 UTC) #1
robliao
Committed patchset #1 manually as 287361 (tree was closed).
6 years, 4 months ago (2014-08-04 17:58:42 UTC) #2
nednguyen
On 2014/08/04 17:57:24, robliao wrote: I think the test to disable is TraceOptionsTest.TraceOptionsFromString
6 years, 4 months ago (2014-08-04 17:58:51 UTC) #3
robliao
On 2014/08/04 17:58:51, nednguyen wrote: > On 2014/08/04 17:57:24, robliao wrote: > > I think ...
6 years, 4 months ago (2014-08-04 17:59:36 UTC) #4
robliao
6 years, 4 months ago (2014-08-04 18:04:41 UTC) #5
robliao
6 years, 4 months ago (2014-08-04 18:05:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as 287362 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698