LayoutTests/editing/spelling/spellcheck-editable-on-focus.html - Issue 43803002: dumpAsText() is unnecessarily called in spellchecking tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/spelling/spellcheck-editable-on-focus.html

Issue 43803002: dumpAsText() is unnecessarily called in spellchecking tests (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../editing.js"></script>	4 <script src="../editing.js"></script>

5 <script src="resources/util.js"></script>	5 <script src="resources/util.js"></script>

6 <script src="../../fast/js/resources/js-test-pre.js"></script>	6 <script src="../../fast/js/resources/js-test-pre.js"></script>

7 </head>	7 </head>

8 <body onload="test();">	8 <body onload="test();">

9 <pre id="console"></pre>	9 <pre id="console"></pre>

10 <div id="container">	10 <div id="container">

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 \|\| !internals.markerCountForNode(findFirstTextNode(testTextField), " spelling"))) {	43 \|\| !internals.markerCountForNode(findFirstTextNode(testTextField), " spelling"))) {

44 window.setTimeout(function() { waitForMarkersToAppear(nretry - 1); } , 5);	44 window.setTimeout(function() { waitForMarkersToAppear(nretry - 1); } , 5);

45 } else {	45 } else {

46 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextAre a), "spelling")', '3');	46 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextAre a), "spelling")', '3');

47 shouldBe('internals.markerCountForNode(findFirstTextNode(testEditabl e), "spelling")', '3');	47 shouldBe('internals.markerCountForNode(findFirstTextNode(testEditabl e), "spelling")', '3');

48 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextFie ld), "spelling")', '3');	48 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextFie ld), "spelling")', '3');

49 finishJSTest();	49 finishJSTest();

50 }	50 }

51 }	51 }

52	52

53 if (window.testRunner) {

54 testRunner.dumpAsText();

55 testRunner.waitUntilDone();

56 }

57

58 shouldBe('internals.markerCountForNode(findFirstTextNode(testEditable), "spe lling")', '0');	53 shouldBe('internals.markerCountForNode(findFirstTextNode(testEditable), "spe lling")', '0');

59 testEditable.focus();	54 testEditable.focus();

60 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextArea), "spe lling")', '0');	55 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextArea), "spe lling")', '0');

61 testTextArea.focus();	56 testTextArea.focus();

62 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextField), "sp elling")', '0');	57 shouldBe('internals.markerCountForNode(findFirstTextNode(testTextField), "sp elling")', '0');

63 testTextField.focus();	58 testTextField.focus();

64 waitForMarkersToAppear(10);	59 waitForMarkersToAppear(10);

65 }	60 }

66	61

67 </script>	62 </script>

68 <script src="../../fast/js/resources/js-test-post.js"></script>	63 <script src="../../fast/js/resources/js-test-post.js"></script>

69 </body>	64 </body>

70 </html>	65 </html>

OLD	NEW