Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 438023004: Enable gpu Debug markers if tracing category skia.gpu is enabled (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Enable gpu Debug markers if tracing category skia.gpu is enabled BUG=skia: Committed: https://skia.googlesource.com/skia/+/6d7f5faeb3f1745bd1fb90c8a2a0655a9e416e4a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Test #

Patch Set 3 : Remove old enable flag #

Total comments: 1

Patch Set 4 : Uniquify var names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -22 lines) Patch
M include/gpu/GrContext.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/GrTracing.h View 1 2 3 2 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
egdaniel
6 years, 4 months ago (2014-08-04 15:17:41 UTC) #1
bsalomon
https://codereview.chromium.org/438023004/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.chromium.org/438023004/diff/1/src/gpu/GrContext.cpp#newcode114 src/gpu/GrContext.cpp:114: // Check if the gpu.serivce category is set from ...
6 years, 4 months ago (2014-08-04 15:22:06 UTC) #2
egdaniel
New version connects the enableGpuTracing to the skia.gpu flag to decide whether or not to ...
6 years, 4 months ago (2014-08-04 19:04:24 UTC) #3
bsalomon
lgtm w/ comment about var name uniqueness. https://codereview.chromium.org/438023004/diff/40001/src/gpu/GrTracing.h File src/gpu/GrTracing.h (right): https://codereview.chromium.org/438023004/diff/40001/src/gpu/GrTracing.h#newcode90 src/gpu/GrTracing.h:90: bool gpuTracingEnabled; ...
6 years, 4 months ago (2014-08-04 19:07:34 UTC) #4
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-08-04 19:44:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/438023004/60001
6 years, 4 months ago (2014-08-04 19:44:28 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-04 19:54:43 UTC) #7
Message was sent while issue was closed.
Change committed as 6d7f5faeb3f1745bd1fb90c8a2a0655a9e416e4a

Powered by Google App Engine
This is Rietveld 408576698