Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: chrome/browser/ssl/ssl_browser_tests.cc

Issue 438010: Moving two tests to FLAKY tests. (Closed)
Patch Set: comment fix Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/find_bar_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_browser_tests.cc
diff --git a/chrome/browser/ssl/ssl_browser_tests.cc b/chrome/browser/ssl/ssl_browser_tests.cc
index 1266be8cfab74f17c2dddd8fe53cc2a23ea8a0c5..e6248564ecc7c2e33adb034643aef59e5776802f 100644
--- a/chrome/browser/ssl/ssl_browser_tests.cc
+++ b/chrome/browser/ssl/ssl_browser_tests.cc
@@ -224,7 +224,15 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSExpiredCertAndDontProceed) {
// link with a blank target). This is to test that the lack of navigation entry
// does not cause any problems (it was causing a crasher, see
// http://crbug.com/19941).
+#if !defined(OS_LINUX) || !defined(TOOLKIT_VIEWS)
IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSErrorWithNoNavEntry) {
+#else
+// TODO(jcampan|oshima): On linux/views, the WaitForLoadStop call
+// below sometimes waits forever because LOAD_STOP notification can
+// happen before WaitLorLoadStop is called. Marking this test as Fleaky.
+// See http://crbug/28098.
+IN_PROC_BROWSER_TEST_F(SSLUITest, FLAKY_TestHTTPSErrorWithNoNavEntry) {
+#endif
scoped_refptr<HTTPTestServer> http_server = PlainServer();
ASSERT_TRUE(http_server.get() != NULL);
scoped_refptr<HTTPSTestServer> bad_https_server = BadCertServer();
@@ -249,9 +257,6 @@ IN_PROC_BROWSER_TEST_F(SSLUITest, TestHTTPSErrorWithNoNavEntry) {
EXPECT_EQ(2, browser()->tab_count());
EXPECT_EQ(1, browser()->selected_index());
- // TODO(jcampan|oshima): Following code waits forever on linux/views
- // because LOAD_STOP notification is issued before WaitLorLoadStop
- // is called. See http://crbug/28098.
#if !defined(OS_LINUX) || !defined(TOOLKIT_VIEWS)
// Since the navigation was initiated by the renderer (when we clicked on the
// link) and since the main page network request failed, we won't get a
« no previous file with comments | « no previous file | chrome/browser/views/find_bar_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698