[SyncFS] Remove usage of file task runner under drive_backend/

[SyncFS] Remove usage of file task runner under drive_backend/


BUG=347425
TEST=./unit_tests --gtest_filter="RemoteTo*:LocalTo*:Metadata*:DriveBackend*:ListChange*:Register"

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287303

[peria, 2014-08-04 04:58:13]

PTL

[nhiroki, 2014-08-04 05:27:15]

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:582:
metadata_database->worker_task_runner_;
nit: You can just call "metadata_database->worker_task_runner_->PostTask(...)"
at line 587.

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1419: const
CreateCallback& callback) {
Can you check 'worker_sequence_checker_' here?

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1437:
DCHECK(worker_task_runner_->RunsTasksOnCurrentThread());
You may have to use "worker_sequence_checker_".

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1725:
base::Bind(callback, LevelDBStatusToSyncStatusCode(status)));
I guess you don't have to post a task here since you are already on the worker
task runner as per the check at line 1713.

[nhiroki, 2014-08-04 05:28:45]

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:582:
metadata_database->worker_task_runner_;
On 2014/08/04 05:27:14, nhiroki wrote:
> nit: You can just call "metadata_database->worker_task_runner_->PostTask(...)"
> at line 587.

Oops... sorry. I missed that |metadata_database| will be reset at line 585.
Please ignore this comment.

[tzik, 2014-08-04 05:35:51]

lgtm

[peria, 2014-08-04 05:52:34]

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
File chrome/browser/sync_file_system/drive_backend/metadata_database.cc (right):

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:582:
metadata_database->worker_task_runner_;
On 2014/08/04 05:28:44, nhiroki wrote:
> On 2014/08/04 05:27:14, nhiroki wrote:
> > nit: You can just call
"metadata_database->worker_task_runner_->PostTask(...)"
> > at line 587.
> 
> Oops... sorry. I missed that |metadata_database| will be reset at line 585.
> Please ignore this comment.

Acknowledged.

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1419: const
CreateCallback& callback) {
On 2014/08/04 05:27:14, nhiroki wrote:
> Can you check 'worker_sequence_checker_' here?

This is a static method, so we cannot use member variables.
I used |create_param->worker_task_runner| instead.

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1437:
DCHECK(worker_task_runner_->RunsTasksOnCurrentThread());
On 2014/08/04 05:27:15, nhiroki wrote:
> You may have to use "worker_sequence_checker_".

Done.

https://codereview.chromium.org/437943002/diff/20001/chrome/browser/sync_file...
chrome/browser/sync_file_system/drive_backend/metadata_database.cc:1725:
base::Bind(callback, LevelDBStatusToSyncStatusCode(status)));
On 2014/08/04 05:27:15, nhiroki wrote:
> I guess you don't have to post a task here since you are already on the worker
> task runner as per the check at line 1713.

Done.

[nhiroki, 2014-08-04 06:18:26]

Thanks! LGTM!!

[peria, 2014-08-04 06:22:30]

The CQ bit was checked by peria@chromium.org

[commit-bot: I haz the power, 2014-08-04 06:23:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/peria@chromium.org/437943002/40001

[commit-bot: I haz the power, 2014-08-04 08:20:37]

Change committed as 287303