Make the root_namespace argument to json_schema_compiler.gypi a string

Make the root_namespace argument to json_schema_compiler.gypi a string
pattern rather than a prefix.

BUG=370952
R=yoz@chromium.org
TBR=dmazzoni@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287488

[not at google - send to devlin, 2014-08-04 22:00:59]

Ok, stage 1. Took me longer than expected because I needed to disentangle some
of the weird path assumptions in the compiler and misnamings.

[not at google - send to devlin, 2014-08-04 22:01:32]

https://codereview.chromium.org/437883002/diff/20001/ui/accessibility/accessi...
File ui/accessibility/accessibility.gyp (right):

https://codereview.chromium.org/437883002/diff/20001/ui/accessibility/accessi...
ui/accessibility/accessibility.gyp:112: 'root_namespace': 'ui',
@dtseng FYI

[Yoyo Zhou, 2014-08-05 00:28:45]

LGTM, nits

https://chromiumcodereview.appspot.com/437883002/diff/20001/build/json_schema...
File build/json_schema_bundle_compile.gypi (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/build/json_schema...
build/json_schema_bundle_compile.gypi:13: #     A Python string substituion
pattern used to generate the C++
check indentation

https://chromiumcodereview.appspot.com/437883002/diff/20001/build/json_schema...
build/json_schema_bundle_compile.gypi:15: #     namespace, like
"toplevel::%(namespace)_api".
%(namespace)s

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
File tools/json_schema_compiler/compiler.py (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
tools/json_schema_compiler/compiler.py:82: filename_without_extension, _ =
os.path.splitext(filename)
This is called "file_base" in the bundles file. Maybe that's better. Or
"filename_base".

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
File tools/json_schema_compiler/cpp_bundle_generator.py (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
tools/json_schema_compiler/cpp_bundle_generator.py:53: # files, without the last
component of the namespace. A cleaner way to do
nit: no comma

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
File tools/json_schema_compiler/cpp_util_test.py (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
tools/json_schema_compiler/cpp_util_test.py:57: def testOpenNamespace(self):
This shouldn't be named this.

[not at google - send to devlin, 2014-08-05 00:45:36]

https://chromiumcodereview.appspot.com/437883002/diff/20001/build/json_schema...
File build/json_schema_bundle_compile.gypi (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/build/json_schema...
build/json_schema_bundle_compile.gypi:13: #     A Python string substituion
pattern used to generate the C++
On 2014/08/05 00:28:44, Yoyo Zhou wrote:
> check indentation

Done.

https://chromiumcodereview.appspot.com/437883002/diff/20001/build/json_schema...
build/json_schema_bundle_compile.gypi:15: #     namespace, like
"toplevel::%(namespace)_api".
On 2014/08/05 00:28:44, Yoyo Zhou wrote:
> %(namespace)s

Done.

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
File tools/json_schema_compiler/compiler.py (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
tools/json_schema_compiler/compiler.py:82: filename_without_extension, _ =
os.path.splitext(filename)
On 2014/08/05 00:28:45, Yoyo Zhou wrote:
> This is called "file_base" in the bundles file. Maybe that's better. Or
> "filename_base".

Done.

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
File tools/json_schema_compiler/cpp_bundle_generator.py (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
tools/json_schema_compiler/cpp_bundle_generator.py:53: # files, without the last
component of the namespace. A cleaner way to do
On 2014/08/05 00:28:45, Yoyo Zhou wrote:
> nit: no comma

Done.

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
File tools/json_schema_compiler/cpp_util_test.py (right):

https://chromiumcodereview.appspot.com/437883002/diff/20001/tools/json_schema...
tools/json_schema_compiler/cpp_util_test.py:57: def testOpenNamespace(self):
On 2014/08/05 00:28:45, Yoyo Zhou wrote:
> This shouldn't be named this.

Done.

[not at google - send to devlin, 2014-08-05 00:45:38]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-08-05 00:49:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/437883002/40001

[commit-bot: I haz the power, 2014-08-05 02:23:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/42327)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_dbg_triggered_tests on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tri...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...)
  win_chromium_x64_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-05 02:27:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-05 02:27:07]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[not at google - send to devlin, 2014-08-05 02:47:14]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-08-05 02:47:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/437883002/60001

[not at google - send to devlin, 2014-08-05 03:26:10]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2014-08-05 03:27:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/437883002/80001

[not at google - send to devlin, 2014-08-05 04:37:45]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2014-08-05 04:37:59]

https://codereview.chromium.org/437883002/diff/100001/tools/json_schema_compi...
File tools/json_schema_compiler/cpp_util.py (right):

https://codereview.chromium.org/437883002/diff/100001/tools/json_schema_compi...
tools/json_schema_compiler/cpp_util.py:154: cpp_namespace =
pattern.replace('%%', '%') % { 'namespace': namespace }
after some debugging, turns out I needed to do this. only an issue on windows
builds. +brettw FYI, any idea what this could have been?

[commit-bot: I haz the power, 2014-08-05 04:39:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kalman@chromium.org/437883002/100001

[commit-bot: I haz the power, 2014-08-05 08:02:15]

Change committed as 287488

[popparod27, 2016-05-15 09:29:17]

popparod27@gmail.com changed reviewers:
+ popparod27@gmail.com