Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 437873002: Fix scrollbar painting problems in pdf files in HiDPI mode with fractional scales. (Closed)

Created:
6 years, 4 months ago by ananta
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix scrollbar painting problems in pdf files in HiDPI mode with fractional scales. Reason for the bug is painting code in the pdf plugin which converts back and forth from pixels to DIP and back to pixels causing us to draw over the scrollbars. Division and multiplication with fractional scales Is a lossy operation. BUG=399150 TEST=Tested manually with fractional scales on Windows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287952

Patch Set 1 #

Patch Set 2 : Reverted debugging changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M pdf/instance.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
ananta
6 years, 4 months ago (2014-08-02 00:17:21 UTC) #1
ananta
6 years, 4 months ago (2014-08-02 00:27:13 UTC) #2
ananta
+jhorwich
6 years, 4 months ago (2014-08-02 00:27:39 UTC) #3
ananta
6 years, 4 months ago (2014-08-02 00:28:34 UTC) #4
ananta
+gene
6 years, 4 months ago (2014-08-06 22:51:15 UTC) #5
gene
lgtm
6 years, 4 months ago (2014-08-06 22:55:13 UTC) #6
ananta
The CQ bit was checked by ananta@chromium.org
6 years, 4 months ago (2014-08-06 23:06:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ananta@chromium.org/437873002/20001
6 years, 4 months ago (2014-08-06 23:11:53 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 4 months ago (2014-08-07 02:23:54 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 03:24:29 UTC) #10
Message was sent while issue was closed.
Change committed as 287952

Powered by Google App Engine
This is Rietveld 408576698