Source/core/editing/VisibleUnits.cpp - Issue 437843002: Invalid caret at the end of line in overtype mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 437843002: Invalid caret at the end of line in overtype mode (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisibleUnits.cpp

diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp

index 64518ec2174effabb75b274eda7c18bbd87dbaac..fe2d37e981ec22eea4846e8caa42da4c42b23855 100644

--- a/Source/core/editing/VisibleUnits.cpp

+++ b/Source/core/editing/VisibleUnits.cpp

@@ -896,6 +896,11 @@ bool isEndOfLine(const VisiblePosition &p)

return p.isNotNull() && p == endOfLine(p);

}

+bool isLogicalEndOfLine(const VisiblePosition &p)

+ return p.isNotNull() && p == logicalEndOfLine(p);

static inline IntPoint absoluteLineDirectionPointToLocalPointInBlock(RootInlineBox* root, int lineDirectionPoint)

{

ASSERT(root);