change opus sample format to kSampleFormatF32

change opus sample format to kSampleFormatF32

Playing a WebM File with opus audio via MediaSource currently uses
kSampleFormatS16. In a video src it uses kSampleFormatF32.
S16 does not work (just plays noise).

BUG=400247
R=vigneshv@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287743

[DaleCurtis, 2014-08-04 20:03:00]

Hmm, are you saying that OPUS in MSE works if it's just audio, but in a muxed
audio/video situation the sample format is wrong?

[DaleCurtis, 2014-08-04 20:04:30]

https://codereview.chromium.org/437813005/diff/1/media/formats/webm/webm_audi...
File media/formats/webm/webm_audio_client.cc (right):

https://codereview.chromium.org/437813005/diff/1/media/formats/webm/webm_audi...
media/formats/webm/webm_audio_client.cc:84: (audio_codec == kCodecOpus) ?
kSampleFormatF32 : kSampleFormatPlanarF32,
Might as well move this up to the (audio_codec == kCodecOpus) section above
where we set 48kHz.  I believe Android is actually using S16, so I don't know if
this will do something different there.

[tbutter, 2014-08-04 20:09:54]

On 2014/08/04 20:03:00, DaleCurtis wrote:
> Hmm, are you saying that OPUS in MSE works if it's just audio, but in a muxed
> audio/video situation the sample format is wrong?

No, sorry for the confusion. It does not work with MediaSource, but it works by
specifying it in a video element like this:
<video src="test.webm"/>

In the latter case kSampleFormatF32 is used.

We tested on Windows & OS X. I can't easily test it on Android.

[DaleCurtis, 2014-08-04 20:19:52]

Looks like none of the android code uses sampleformat, so this should be okay.

[DaleCurtis, 2014-08-04 20:20:47]

lgtm % nit.  I removed "NOTRY=true" from the description.  Please don't set that
in general.  It should only be used for non-code changes or reverts.

[vignesh, 2014-08-04 20:21:49]

On 2014/08/04 20:04:30, DaleCurtis wrote:
>
https://codereview.chromium.org/437813005/diff/1/media/formats/webm/webm_audi...
> File media/formats/webm/webm_audio_client.cc (right):
> 
>
https://codereview.chromium.org/437813005/diff/1/media/formats/webm/webm_audi...
> media/formats/webm/webm_audio_client.cc:84: (audio_codec == kCodecOpus) ?
> kSampleFormatF32 : kSampleFormatPlanarF32,
> Might as well move this up to the (audio_codec == kCodecOpus) section above
> where we set 48kHz.  I believe Android is actually using S16, so I don't know
if
> this will do something different there.

i don't think this affects android as it doesn't use kSampleFormat* code.

so lgtm.

[tbutter, 2014-08-06 06:23:14]

The CQ bit was checked by tbutter@gmail.com

[commit-bot: I haz the power, 2014-08-06 06:24:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tbutter@gmail.com/437813005/20001

[commit-bot: I haz the power, 2014-08-06 09:22:14]

Change committed as 287743