Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 437793002: Componentize AutocompleteProviderListener (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, James Su, extensions-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Componentize AutocompleteProviderListener BUG=388515 TEST=build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287258

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -45 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/autocomplete/autocomplete_provider_listener.h View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_extensions_delegate_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/keyword_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autocomplete.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + components/autocomplete/autocomplete_provider_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hashimoto
6 years, 4 months ago (2014-08-01 08:29:29 UTC) #1
Peter Kasting
RSLGTM
6 years, 4 months ago (2014-08-02 01:12:47 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-03 10:38:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/437793002/1
6 years, 4 months ago (2014-08-03 10:38:44 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 12:48:54 UTC) #5
Message was sent while issue was closed.
Change committed as 287258

Powered by Google App Engine
This is Rietveld 408576698