Issue 43773003: Remove virtual destructors for several platform support classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43773003: Remove virtual destructors for several platform support classes (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
pilgrim_google, abarth-chromium

CC:
blink-reviews, tommyw+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove virtual destructors for several platform support classes Remove destructors for the following platform support classes: WebRTCICECandidatePrivate, WebRTCSessionDescriptionPrivate and WebSourceInfoPrivate. Those destructors were empty and marked as virtual. This avoid creating unnecessary vtables since these classes are never subclassed, nor do they have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160594

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -15 lines)			Patch
M	Source/core/platform/chromium/support/WebRTCICECandidate.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/platform/chromium/support/WebRTCSessionDescription.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	Source/core/platform/chromium/support/WebSourceInfo.cpp	View	2 chunks	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/43773003/1

7 years, 1 month ago (2013-10-25 16:03:40 UTC) #3

Message was sent while issue was closed.

Change committed as 160594

Expand Messages | Collapse Messages