Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 437683002: Wire sync shutdown reason from PSS all the way down to sync manager. (Closed)

Created:
6 years, 4 months ago by haitaol1
Modified:
6 years, 4 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Wire sync shutdown reason from PSS all the way down to sync manager. This is to prepare for on-demand backup where backup manger needs to persist backup data if the shutdown is due to switching to syncing. No behavior changes are introduced by this cl. BUG=362679 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287799

Patch Set 1 #

Patch Set 2 : ToT #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -59 lines) Patch
M chrome/browser/sync/glue/sync_backend_host.h View 2 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 11 chunks +16 lines, -13 lines 0 comments Download
A sync/internal_api/public/shutdown_reason.h View 1 chunk +23 lines, -0 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M sync/internal_api/public/test/fake_sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_backup_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/sync.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
haitaol1
6 years, 4 months ago (2014-07-31 21:43:50 UTC) #1
Nicolas Zea
lgtm
6 years, 4 months ago (2014-08-01 00:34:58 UTC) #2
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-08-05 02:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/437683002/1
6 years, 4 months ago (2014-08-05 02:11:25 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 02:18:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 02:21:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1097) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/1796) win8_chromium_rel ...
6 years, 4 months ago (2014-08-05 02:21:41 UTC) #7
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-08-06 00:05:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/437683002/20001
6 years, 4 months ago (2014-08-06 00:06:18 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-06 06:35:11 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 07:35:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/36635)
6 years, 4 months ago (2014-08-06 07:35:23 UTC) #12
haitaol1
The CQ bit was checked by haitaol@chromium.org
6 years, 4 months ago (2014-08-06 17:30:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/437683002/40001
6 years, 4 months ago (2014-08-06 17:32:02 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 17:34:32 UTC) #15
Message was sent while issue was closed.
Change committed as 287799

Powered by Google App Engine
This is Rietveld 408576698