mojo/public/tools/bindings/pylib/mojom/generate/pack.py - Issue 437643002: Support nullable types in mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

Issue 437643002: Support nullable types in mojom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: changes according to darin's suggestions Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/tools/bindings/pylib/mojom/generate/module.py ('K') | « mojo/public/tools/bindings/pylib/mojom/generate/module.py ('k') | mojo/public/tools/bindings/pylib/mojom/generate/pack_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

index d6d0152203020395311f6add668f6b4f15171e9d..be8b87556210aaeea200eaa5c12a3f817e4ae959 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

@@ -13,23 +13,29 @@ import module as mojom

class PackedField(object):

kind_to_size = {

- mojom.BOOL: 1,

- mojom.INT8: 1,

- mojom.UINT8: 1,

- mojom.INT16: 2,

- mojom.UINT16: 2,

- mojom.INT32: 4,

- mojom.UINT32: 4,

- mojom.FLOAT: 4,

- mojom.HANDLE: 4,

- mojom.MSGPIPE: 4,

- mojom.SHAREDBUFFER: 4,

- mojom.DCPIPE: 4,

- mojom.DPPIPE: 4,

- mojom.INT64: 8,

- mojom.UINT64: 8,

- mojom.DOUBLE: 8,

- mojom.STRING: 8

+ mojom.BOOL: 1,

+ mojom.INT8: 1,

+ mojom.UINT8: 1,

+ mojom.INT16: 2,

+ mojom.UINT16: 2,

+ mojom.INT32: 4,

+ mojom.UINT32: 4,

+ mojom.FLOAT: 4,

+ mojom.HANDLE: 4,

+ mojom.MSGPIPE: 4,

+ mojom.SHAREDBUFFER: 4,

+ mojom.DCPIPE: 4,

+ mojom.DPPIPE: 4,

+ mojom.NLBL_HANDLE: 4,

+ mojom.NLBL_MSGPIPE: 4,

+ mojom.NLBL_SHAREDBUFFER: 4,

+ mojom.NLBL_DCPIPE: 4,

+ mojom.NLBL_DPPIPE: 4,

+ mojom.INT64: 8,

+ mojom.UINT64: 8,

+ mojom.DOUBLE: 8,

+ mojom.STRING: 8,

+ mojom.NLBL_STRING: 8

}

@classmethod