mojo/public/tools/bindings/pylib/mojom/generate/pack.py - Issue 437643002: Support nullable types in mojom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

Issue 437643002: Support nullable types in mojom. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

index d6d0152203020395311f6add668f6b4f15171e9d..da216b03cf91b5a694453ab408f80899950658ea 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

@@ -34,6 +34,8 @@ class PackedField(object):

@classmethod

def GetSizeForKind(cls, kind):

+ if isinstance(kind, mojom.Nullable):

+ return cls.GetSizeForKind(kind.kind)

if isinstance(kind, (mojom.Array, mojom.Struct, mojom.FixedArray)):

return 8

if isinstance(kind, mojom.Interface) or \