Issue 437623003: Fix testGetVisitedHistoryCallbackAfterDestroy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437623003: Fix testGetVisitedHistoryCallbackAfterDestroy (Closed)

Created:
6 years, 4 months ago by boliu

Modified:
6 years, 4 months ago

Reviewers:
piman

CC:
chromium-reviews, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix testGetVisitedHistoryCallbackAfterDestroy Crash caused by RenderThreadImpl::OnMemoryPressure being called before blink is initialized. Fix by skipping the crashing code if blink has not been initialized. BUG=398768 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287167

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -6 lines)			Patch
	M	android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientVisitedHistoryTest.java	View		2 chunks	+0 lines, -5 lines	0 comments	Download
	M	content/renderer/render_thread_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/437623003/1

6 years, 4 months ago (2014-08-01 19:39:15 UTC) #4

Message was sent while issue was closed.

Change committed as 287167

Expand Messages | Collapse Messages