Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 437593007: Don't rotate WebCursor based on display rotation in X11 Aura. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't rotate WebCursor based on display rotation in X11 Aura. Since we now correctly report display rotations (ie. non 0 values), this caused a regression. The Ozone backend might not require this too. BUG=399571 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/common/cursors/webcursor.h View 1 chunk +4 lines, -1 line 0 comments Download
M content/common/cursors/webcursor_aurax11.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mlamouri (slow - plz ping)
jam@, this is fixing a regression. Could you prioritize the review accordingly? Thanks! :)
6 years, 4 months ago (2014-08-01 13:31:42 UTC) #1
mlamouri (slow - plz ping)
+jochen@ jam@ was OOO, I'm not sure if he is back. This is fixing a ...
6 years, 4 months ago (2014-08-05 20:09:54 UTC) #2
mlamouri (slow - plz ping)
On 2014/08/05 20:09:54, Mounir Lamouri wrote: > +jochen@ > > jam@ was OOO, I'm not ...
6 years, 4 months ago (2014-08-06 14:17:53 UTC) #3
jam
lgtm
6 years, 4 months ago (2014-08-07 05:47:55 UTC) #4
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-08-07 09:21:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/437593007/1
6 years, 4 months ago (2014-08-07 09:23:22 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 16:01:25 UTC) #7
Message was sent while issue was closed.
Change committed as 288059

Powered by Google App Engine
This is Rietveld 408576698