Video Player: Install the cast API extension if it is not installed.

Video Player: Install the cast API extension if it is not installed.

Previously, Video Player tried loading even if it's not installed. This patch checks the status of load and if the load is failed, installs the extension in background and tries loading again.

BUG=399557
TEST=manually tested
R=hirono@chromium.org, kinaba@chromium.org
TBR=mkearney@chromium.org
# TBRing for adding argument to private API in the idl file.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287280

[yoshiki, 2014-08-01 09:19:56]

@hashimoto, could you take a look? Thanks.

[yoshiki, 2014-08-01 09:33:18]

+hirono, could you take a look at JavaScript part? Thanks.

[hirono, 2014-08-01 09:58:08]

lgtm with two nits

https://codereview.chromium.org/437593006/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/437593006/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_browser_private.idl:788: // |callback|
Please add comment for silentInstallation.

https://codereview.chromium.org/437593006/diff/60001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/437593006/diff/60001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/caster.js:35: * @param {function} callback
Callback (executed asynchronously).
nit: jsdoc for opt_secondTry

[hashimoto, 2014-08-01 10:40:31]

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/app_installer.cc (right):

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/app_installer.cc:50: silent_installation_ =
false;
Can't we raise an error in this case?

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/app_installer.h (right):

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/app_installer.h:26: bool silent,
nit: silent_installation

[yoshiki, 2014-08-01 11:46:41]

@hashimoto, PTAL.

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/app_installer.cc (right):

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/app_installer.cc:50: silent_installation_ =
false;
On 2014/08/01 10:40:31, hashimoto wrote:
> Can't we raise an error in this case?

Done. This handles in the caller.

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/app_installer.h (right):

https://codereview.chromium.org/437593006/diff/60001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/app_installer.h:26: bool silent,
On 2014/08/01 10:40:31, hashimoto wrote:
> nit: silent_installation

Done.

https://codereview.chromium.org/437593006/diff/60001/chrome/common/extensions...
File chrome/common/extensions/api/file_browser_private.idl (right):

https://codereview.chromium.org/437593006/diff/60001/chrome/common/extensions...
chrome/common/extensions/api/file_browser_private.idl:788: // |callback|
On 2014/08/01 09:58:08, hirono wrote:
> Please add comment for silentInstallation.

Done.

https://codereview.chromium.org/437593006/diff/60001/ui/file_manager/video_pl...
File ui/file_manager/video_player/js/cast/caster.js (right):

https://codereview.chromium.org/437593006/diff/60001/ui/file_manager/video_pl...
ui/file_manager/video_player/js/cast/caster.js:35: * @param {function} callback
Callback (executed asynchronously).
On 2014/08/01 09:58:08, hirono wrote:
> nit: jsdoc for opt_secondTry

Done.

[yoshiki, 2014-08-01 15:33:48]

@kinaba-san, could you take a look if you have a time? Thanks

[kinaba, 2014-08-01 15:56:02]

lgtm

[yoshiki, 2014-08-01 16:20:20]

The CQ bit was checked by yoshiki@chromium.org

[commit-bot: I haz the power, 2014-08-01 16:22:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoshiki@chromium.org/437593006/100001

[commit-bot: I haz the power, 2014-08-01 23:43:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-01 23:47:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-01 23:47:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yoshiki, 2014-08-04 02:58:23]

Committed patchset #4 manually as 287280 (presubmit successful).