Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Side by Side Diff: third_party/libxslt/libxslt.gyp

Issue 437543007: Refactor how clang warning flags are set. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'conditions': [ 7 'conditions': [
8 ['os_posix == 1 and OS != "mac"', { 8 ['os_posix == 1 and OS != "mac"', {
9 'os_include': 'linux' 9 'os_include': 'linux'
10 }], 10 }],
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 '../libxml/libxml.gyp:libxml', 99 '../libxml/libxml.gyp:libxml',
100 ], 100 ],
101 'direct_dependent_settings': { 101 'direct_dependent_settings': {
102 'defines': [ 102 'defines': [
103 'LIBXSLT_STATIC', 103 'LIBXSLT_STATIC',
104 ], 104 ],
105 'include_dirs': [ 105 'include_dirs': [
106 '.', 106 '.',
107 ], 107 ],
108 }, 108 },
109 'variables': {
110 'clang_warning_flags': [
111 # libxslt stores a char[3] in a `const unsigned char*`.
112 '-Wno-pointer-sign',
113 ],
114 },
109 'conditions': [ 115 'conditions': [
110 ['OS!="win"', {'product_name': 'xslt'}], 116 ['OS!="win"', {'product_name': 'xslt'}],
111 ['clang == 1', {
112 'xcode_settings': {
113 'WARNING_CFLAGS': [
114 # libxslt stores a char[3] in a `const unsigned char*`.
115 '-Wno-pointer-sign',
116 ],
117 },
118 'cflags': [
119 '-Wno-pointer-sign',
120 ],
121 }],
122 ], 117 ],
123 }], 118 }],
124 ], 119 ],
125 }, 120 },
126 ], 121 ],
127 } 122 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698