Refactor how clang warning flags are set.

skia/skia_common.gypi

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This gypi file handles the removal of platform-specific files from the
 # Skia build.
 {
   'includes': [
     # skia_for_chromium_defines.gypi defines skia_for_chromium_defines
     '../third_party/skia/gyp/skia_for_chromium_defines.gypi',
@@ skipping 119 matching lines @@
           'skia_support_gpu': 0,
         }, {
           'skia_support_gpu': 1,
         }],
         ['OS=="ios" or enable_printing == 0', {
           'skia_support_pdf': 0,
         }, {
           'skia_support_pdf': 1,
         }],
       ],
+      # TODO(scottmg): http://crbug.com/177306
+      'clang_warning_flags': [
+        # Don't warn about string->bool used in asserts.
+        '-Wstring-conversion',

[hans, 2014/08/14 21:11:02]

I just noticed this: it looks like this is adding a warning, not uppressing it.
How does that work?

[Nico, 2014/08/14 21:15:35]

That looks wrong, it should've probably been clang_warning_flags_unset . Looks
like this isn't needed anymore, then?

[scottmg, 2014/08/14 21:18:10]

Looks like they're mostly gone
https://code.google.com/p/chromium/codesearch#search/&q=assert.*&&.*%...
but might depend on exact build config.

+      ]
     },
     'skia_support_gpu': '<(skia_support_gpu)',
     'skia_support_pdf': '<(skia_support_pdf)',
 
     # These two set the paths so we can include skia/gyp/core.gypi
     'skia_src_path': '../third_party/skia/src',
     'skia_include_path': '../third_party/skia/include',
 
     # This list will contain all defines that also need to be exported to
     # dependent components.
@@ skipping 62 matching lines @@
   # re-export if they include Skia headers in their public headers.
   'all_dependent_settings': {
     'include_dirs': [
       '..',
       'config',
     ],
   },
 
   'msvs_disabled_warnings': [4244, 4267, 4341, 4345, 4390, 4554, 4748, 4800],
 }