Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: src/lookup.h

Issue 437513002: Inline LookupInHolder and NextHolder (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Don't recreate a handle for the map if it didn't change Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « BUILD.gn ('k') | src/lookup.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LOOKUP_H_ 5 #ifndef V8_LOOKUP_H_
6 #define V8_LOOKUP_H_ 6 #define V8_LOOKUP_H_
7 7
8 #include "src/factory.h" 8 #include "src/factory.h"
9 #include "src/isolate.h" 9 #include "src/isolate.h"
10 #include "src/objects.h" 10 #include "src/objects.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 } 138 }
139 Handle<Object> GetAccessors() const; 139 Handle<Object> GetAccessors() const;
140 Handle<Object> GetDataValue() const; 140 Handle<Object> GetDataValue() const;
141 void WriteDataValue(Handle<Object> value); 141 void WriteDataValue(Handle<Object> value);
142 142
143 void InternalizeName(); 143 void InternalizeName();
144 144
145 private: 145 private:
146 Handle<Map> GetReceiverMap() const; 146 Handle<Map> GetReceiverMap() const;
147 147
148 MUST_USE_RESULT bool NextHolder(); 148 MUST_USE_RESULT inline JSReceiver* NextHolder(Map* map);
149 State LookupInHolder(); 149 inline State LookupInHolder(Map* map);
150 Handle<Object> FetchValue() const; 150 Handle<Object> FetchValue() const;
151 151
152 bool IsBootstrapping() const; 152 bool IsBootstrapping() const;
153 153
154 // Methods that fetch data from the holder ensure they always have a holder. 154 // Methods that fetch data from the holder ensure they always have a holder.
155 // This means the receiver needs to be present as opposed to just the receiver 155 // This means the receiver needs to be present as opposed to just the receiver
156 // map. Other objects in the prototype chain are transitively guaranteed to be 156 // map. Other objects in the prototype chain are transitively guaranteed to be
157 // present via the receiver map. 157 // present via the receiver map.
158 bool is_guaranteed_to_have_holder() const { 158 bool is_guaranteed_to_have_holder() const {
159 return !maybe_receiver_.is_null(); 159 return !maybe_receiver_.is_null();
(...skipping 23 matching lines...) Expand all
183 MaybeHandle<Object> maybe_receiver_; 183 MaybeHandle<Object> maybe_receiver_;
184 MaybeHandle<JSReceiver> maybe_holder_; 184 MaybeHandle<JSReceiver> maybe_holder_;
185 185
186 int number_; 186 int number_;
187 }; 187 };
188 188
189 189
190 } } // namespace v8::internal 190 } } // namespace v8::internal
191 191
192 #endif // V8_LOOKUP_H_ 192 #endif // V8_LOOKUP_H_
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698