Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 437513002: Inline LookupInHolder and NextHolder (Closed)

Created:
6 years, 4 months ago by Toon Verwaest
Modified:
6 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Inline LookupInHolder and NextHolder BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22853

Patch Set 1 #

Patch Set 2 : Don't recreate a handle for the map if it didn't change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -62 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/lookup.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/lookup.cc View 1 3 chunks +24 lines, -60 lines 0 comments Download
A src/lookup-inl.h View 1 chunk +68 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 4 months ago (2014-07-31 09:41:55 UTC) #1
Jakob Kummerow
lgtm
6 years, 4 months ago (2014-07-31 13:27:33 UTC) #2
Toon Verwaest
6 years, 4 months ago (2014-08-05 09:33:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as 22853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698