Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 437483004: Fix unninitialized 'tmp' in CJBig2_Image::composeTo_opt2 (Closed)

Created:
6 years, 4 months ago by jun_fang
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, palmer, Bo Xu
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Fix unninitialized 'tmp' in CJBig2_Image::composeTo_opt2 BUG=387811 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/06a8c87

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M core/src/fxcodec/jbig2/JBig2_Image.cpp View 1 4 chunks +11 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jun_fang
please review this fix.
6 years, 4 months ago (2014-08-04 04:39:08 UTC) #1
Tom Sepez
https://codereview.chromium.org/437483004/diff/1/core/src/fxcodec/jbig2/JBig2_Image.cpp File core/src/fxcodec/jbig2/JBig2_Image.cpp (right): https://codereview.chromium.org/437483004/diff/1/core/src/fxcodec/jbig2/JBig2_Image.cpp#newcode795 core/src/fxcodec/jbig2/JBig2_Image.cpp:795: } else { can we remove some of these ...
6 years, 4 months ago (2014-08-04 17:58:22 UTC) #2
jun_fang
6 years, 4 months ago (2014-08-04 18:55:12 UTC) #3
palmer
Does this vulnerability exist in the upstream Jbig2 code?
6 years, 4 months ago (2014-08-04 18:58:41 UTC) #4
jun_fang
On 2014/08/04 18:58:41, Chromium Palmer wrote: > Does this vulnerability exist in the upstream Jbig2 ...
6 years, 4 months ago (2014-08-04 19:10:32 UTC) #5
Tom Sepez
lgtm
6 years, 4 months ago (2014-08-05 17:22:56 UTC) #6
jun_fang
6 years, 4 months ago (2014-08-05 17:53:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r06a8c87 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698