Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 437443006: [Telemetry] Fix android unittests that run after testRendererCrash. (Closed)

Created:
6 years, 4 months ago by tonyg
Modified:
6 years, 4 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix android unittests that run after testRendererCrash. Looks like we have to restart the browser if a tab crashes in a browser that doesn't support tab control. BUG=337829 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287186

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove __class__ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/telemetry/telemetry/unittest/tab_test_case.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tonyg
6 years, 4 months ago (2014-08-01 23:16:52 UTC) #1
dtu
lgtm
6 years, 4 months ago (2014-08-01 23:32:38 UTC) #2
dtu
https://codereview.chromium.org/437443006/diff/1/tools/telemetry/telemetry/unittest/tab_test_case.py File tools/telemetry/telemetry/unittest/tab_test_case.py (right): https://codereview.chromium.org/437443006/diff/1/tools/telemetry/telemetry/unittest/tab_test_case.py#newcode49 tools/telemetry/telemetry/unittest/tab_test_case.py:49: self.__class__.tearDownClass() I think you can exclude the __class__
6 years, 4 months ago (2014-08-01 23:33:10 UTC) #3
tonyg
On 2014/08/01 23:33:10, dtu wrote: > https://codereview.chromium.org/437443006/diff/1/tools/telemetry/telemetry/unittest/tab_test_case.py > File tools/telemetry/telemetry/unittest/tab_test_case.py (right): > > https://codereview.chromium.org/437443006/diff/1/tools/telemetry/telemetry/unittest/tab_test_case.py#newcode49 > ...
6 years, 4 months ago (2014-08-01 23:38:56 UTC) #4
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 4 months ago (2014-08-01 23:39:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/437443006/20001
6 years, 4 months ago (2014-08-01 23:42:01 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 08:03:05 UTC) #7
Message was sent while issue was closed. 
Change committed as 287186

Powered by Google App Engine
This is Rietveld 408576698