Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 437423006: Handle abnormal location information (Closed)

Created:
6 years, 4 months ago by Jaekyun Seok (inactive)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Handle abnormal location information View.getWindowVisibleDisplayFrame() and View.getLocationOnScreen() sometimes return abnormal values in MultiWindow mode. BUG=387668 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287948

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Jaekyun Seok (inactive)
The CQ bit was checked by jaekyun@chromium.org
6 years, 4 months ago (2014-08-05 23:25:15 UTC) #1
Jaekyun Seok (inactive)
The CQ bit was unchecked by jaekyun@chromium.org
6 years, 4 months ago (2014-08-05 23:25:16 UTC) #2
Jaekyun Seok (inactive)
Please review this patch.
6 years, 4 months ago (2014-08-06 00:07:39 UTC) #3
David Trainor- moved to gerrit
lgtm
6 years, 4 months ago (2014-08-06 19:48:05 UTC) #4
Jaekyun Seok (inactive)
The CQ bit was checked by jaekyun@chromium.org
6 years, 4 months ago (2014-08-06 23:32:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jaekyun@chromium.org/437423006/1
6 years, 4 months ago (2014-08-06 23:32:38 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-07 03:04:08 UTC) #7
Message was sent while issue was closed.
Change committed as 287948

Powered by Google App Engine
This is Rietveld 408576698