Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: components/bookmarks/browser/bookmark_utils_unittest.cc

Issue 437423005: Show paste option on right click of bookmark bar if some URL is copied from outside browser or from… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created new test assertion Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/bookmark_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/bookmarks/browser/bookmark_utils_unittest.cc
diff --git a/components/bookmarks/browser/bookmark_utils_unittest.cc b/components/bookmarks/browser/bookmark_utils_unittest.cc
index 75daeebb6c668562c9f6a2df424c6139382f0f58..8248016432d5afefee822ca00a6b13d7c32895e6 100644
--- a/components/bookmarks/browser/bookmark_utils_unittest.cc
+++ b/components/bookmarks/browser/bookmark_utils_unittest.cc
@@ -257,6 +257,36 @@ TEST_F(BookmarkUtilsTest, GetBookmarksMatchingPropertiesConjunction) {
// Copy and paste is not yet supported on iOS. http://crbug.com/228147
#if !defined(OS_IOS)
+TEST_F(BookmarkUtilsTest, PasteBookmarkFromURL) {
+ test::TestBookmarkClient client;
+ scoped_ptr<BookmarkModel> model(client.CreateModel());
+ const base::string16 url_text = ASCIIToUTF16("http://www.google.com/");
+ const BookmarkNode* bookmark_bar = model->bookmark_bar_node();
+
+ // Write some valid url to the clipboard.
+ ui::ScopedClipboardWriter clipboard_writer(
+ ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
+ clipboard_writer.WriteText(url_text);
+
+ // Now we should be able to paste from the clipboard.
+ EXPECT_TRUE(CanPasteFromClipboard(model.get(), bookmark_bar));
+
+ PasteFromClipboard(model.get(), bookmark_bar, 0);
+ ASSERT_EQ(1, bookmark_bar->child_count());
+
+ // Url for added node should be same as url_text.
+ EXPECT_EQ(url_text, ASCIIToUTF16(bookmark_bar->GetChild(0)->url().spec()));
+
+ // Write blank text to clipboard.
+ {
+ ui::ScopedClipboardWriter clipboard_writer(
+ ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
+ clipboard_writer.WriteText(ASCIIToUTF16(""));
sky 2014/09/09 15:52:29 ASCIIToUTF16("")->base::string16()
ankit 2014/09/10 13:18:47 Done.
+ }
+ // Now we shouldn't be able to paste from the clipboard.
+ EXPECT_FALSE(CanPasteFromClipboard(model.get(), bookmark_bar));
+}
+
TEST_F(BookmarkUtilsTest, CopyPaste) {
test::TestBookmarkClient client;
scoped_ptr<BookmarkModel> model(client.CreateModel());
« no previous file with comments | « components/bookmarks/browser/bookmark_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698