Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/bookmarks/browser/bookmark_utils_unittest.cc

Issue 437423005: Show paste option on right click of bookmark bar if some URL is copied from outside browser or from… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added unit tests Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/bookmarks/browser/bookmark_utils_unittest.cc
diff --git a/components/bookmarks/browser/bookmark_utils_unittest.cc b/components/bookmarks/browser/bookmark_utils_unittest.cc
index 68e084ff072bbfb67b2780a40d80cd50b5c6f445..3950a01556d8d739c0f616cd34acc63ea02cb1fb 100644
--- a/components/bookmarks/browser/bookmark_utils_unittest.cc
+++ b/components/bookmarks/browser/bookmark_utils_unittest.cc
@@ -273,6 +273,14 @@ TEST_F(BookmarkUtilsTest, CopyPaste) {
// And make sure we can paste a bookmark from the clipboard.
EXPECT_TRUE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
+ // Write some valid url to the clipboard.
+ ui::ScopedClipboardWriter clipboard_writer(
+ ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
+ clipboard_writer.WriteText(ASCIIToUTF16("http://www.google.com"));
+
+ // Now we should be able to paste from the clipboard.
+ EXPECT_TRUE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
+
// Write some text to the clipboard.
{
ui::ScopedClipboardWriter clipboard_writer(
@@ -320,6 +328,17 @@ TEST_F(BookmarkUtilsTest, CopyPasteMetaInfo) {
EXPECT_EQ("somevalue", value);
EXPECT_TRUE(pasted->GetMetaInfo("someotherkey", &value));
EXPECT_EQ("someothervalue", value);
+
+ // Write some valid url to clipboard
+ ui::ScopedClipboardWriter clipboard_writer(
+ ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
+ clipboard_writer.WriteText(ASCIIToUTF16("http://www.google.com"));
+
+ // We should be able to paste from clipboard.
+ EXPECT_TRUE(CanPasteFromClipboard(model.get(), folder));
+
+ PasteFromClipboard(model.get(), folder, 1);
+ ASSERT_EQ(2, folder->child_count());
}
#if defined(OS_LINUX) || defined(OS_MACOSX)

Powered by Google App Engine
This is Rietveld 408576698