Show paste option on right click of bookmark bar if some URL is copied from outside browser or from…

components/bookmarks/browser/bookmark_utils.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/browser/bookmark_utils.h"
 
 #include <utility>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
@@ skipping 175 matching lines @@
         model->Remove(filtered_nodes[i]->parent(), index);
     }
   }
 }
 
 void PasteFromClipboard(BookmarkModel* model,
                         const BookmarkNode* parent,
                         int index) {
   if (!parent)
     return;
-
   BookmarkNodeData bookmark_data;
-  if (!bookmark_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE))
+  if (BookmarkNodeData::ClipboardContainsBookmarks()) {
+    if (!bookmark_data.ReadFromClipboard(ui::CLIPBOARD_TYPE_COPY_PASTE))
     return;

[sky, 2014/08/15 18:24:55]

spacing is off.
But I think this would be clearer if you move the !ReadFromClipboard to an else
around 213ish.

[ankit, 2014/08/16 07:43:57]

Please correct if my understanding is not correct.
First check should be whether clipboard has any bookmark or not.
If I do as suggested in that case the order will be reversed.

-
+  } else if (ui::Clipboard::GetForCurrentThread()->IsFormatAvailable(
+                 ui::Clipboard::GetUrlWFormatType(),
+                 ui::CLIPBOARD_TYPE_COPY_PASTE)) {
+    base::string16 url_text;
+    ui::Clipboard::GetForCurrentThread()->ReadText(
+        ui::CLIPBOARD_TYPE_COPY_PASTE, &url_text);
+    GURL url(url_text);
+    if (!url.is_valid())
+      return;
+    BookmarkNode node(url);
+    node.SetTitle(url_text);
+    BookmarkNodeData bookmark(&node);
+    bookmark_data = bookmark;
+  }
   if (index == -1)
     index = parent->child_count();
   ScopedGroupBookmarkActions group_paste(model);
   CloneBookmarkNode(model, bookmark_data.elements, parent, index, true);
 }
 
 bool CanPasteFromClipboard(BookmarkModel* model, const BookmarkNode* node) {
   if (!node || !model->client()->CanBeEditedByUser(node))
     return false;
-  return BookmarkNodeData::ClipboardContainsBookmarks();
+  if (BookmarkNodeData::ClipboardContainsBookmarks())
+    return true;
+  if (ui::Clipboard::GetForCurrentThread()->IsFormatAvailable(

[sky, 2014/08/15 18:24:55]

223-233 is nearly identical to 200-208, refactor to share.

+          ui::Clipboard::GetUrlWFormatType(), ui::CLIPBOARD_TYPE_COPY_PASTE)) {
+    base::string16 url_text;
+    ui::Clipboard::GetForCurrentThread()->ReadText(
+        ui::CLIPBOARD_TYPE_COPY_PASTE, &url_text);
+    GURL url(url_text);
+    if (url.is_valid())
+      return true;
+  }
+  return false;
 }
 
 std::vector<const BookmarkNode*> GetMostRecentlyModifiedUserFolders(
     BookmarkModel* model,
     size_t max_count) {
   std::vector<const BookmarkNode*> nodes;
   ui::TreeNodeIterator<const BookmarkNode> iterator(model->root_node(),
                                                     PruneInvisibleFolders);
 
   while (iterator.has_next()) {
@@ skipping 216 matching lines @@
   }
   return false;
 }
 
 const BookmarkNode* GetBookmarkNodeByID(const BookmarkModel* model, int64 id) {
   // TODO(sky): TreeNode needs a method that visits all nodes using a predicate.
   return GetNodeByID(model->root_node(), id);
 }
 
 }  // namespace bookmarks