Show paste option on right click of bookmark bar if some URL is copied from outside browser or from…

components/bookmarks/browser/bookmark_utils_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bookmarks/browser/bookmark_utils.h"
 
 #include <vector>
 
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 255 matching lines @@
                                            GURL("http://www.google.com"));
 
   // Copy a node to the clipboard.
   std::vector<const BookmarkNode*> nodes;
   nodes.push_back(node);
   CopyToClipboard(model.get(), nodes, false);
 
   // And make sure we can paste a bookmark from the clipboard.
   EXPECT_TRUE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
 
+  // Write some valid url to the clipboard.

[sky, 2014/09/08 16:26:18]

Move your new assertions into their own test. Putting random assertions into
CopyPasteMetaInfo in particular is wrong.

+  ui::ScopedClipboardWriter clipboard_writer(
+      ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
+  clipboard_writer.WriteText(ASCIIToUTF16("http://www.google.com"));
+
+  // Now we should be able to paste from the clipboard.
+  EXPECT_TRUE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
+
+  // Write blank text to clipboard.
+  {
+    ui::ScopedClipboardWriter clipboard_writer(
+        ui::Clipboard::GetForCurrentThread(),
+        ui::CLIPBOARD_TYPE_COPY_PASTE);
+    clipboard_writer.WriteText(ASCIIToUTF16(""));
+  }
+
+  // Now we shouldn't be able to paste from the clipboard.
+  EXPECT_FALSE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
+
   // Write some text to the clipboard.
   {
     ui::ScopedClipboardWriter clipboard_writer(
         ui::Clipboard::GetForCurrentThread(),
         ui::CLIPBOARD_TYPE_COPY_PASTE);
     clipboard_writer.WriteText(ASCIIToUTF16("foo"));
   }
 
   // Now we shouldn't be able to paste from the clipboard.
   EXPECT_FALSE(CanPasteFromClipboard(model.get(), model->bookmark_bar_node()));
@@ skipping 18 matching lines @@
   const BookmarkNode* folder =
       model->AddFolder(model->bookmark_bar_node(), 0, ASCIIToUTF16("Folder"));
   EXPECT_EQ(0, folder->child_count());
 
   // And make sure we can paste a bookmark from the clipboard.
   EXPECT_TRUE(CanPasteFromClipboard(model.get(), folder));
 
   PasteFromClipboard(model.get(), folder, 0);
   ASSERT_EQ(1, folder->child_count());
 
+  // Write some valid url to clipboard

[sky, 2014/09/08 16:26:18]

end with '.'

+  base::string16 url_text =  ASCIIToUTF16("http://www.google.com/");

[sky, 2014/09/08 16:26:18]

you've got two spaces here. And make url_text a const.

+  ui::ScopedClipboardWriter clipboard_writer(
+      ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);
+  clipboard_writer.WriteText(url_text);
+
+  // We should be able to paste from clipboard.
+  EXPECT_TRUE(CanPasteFromClipboard(model.get(), folder));
+
+  PasteFromClipboard(model.get(), folder, 1);
+  ASSERT_EQ(2, folder->child_count());
+
+  // Url for added node should be same as url_text.
+  EXPECT_EQ(url_text,ASCIIToUTF16(folder->GetChild(1)->url().spec()));

[sky, 2014/09/08 16:26:18]

nit: space after ','

+
   // Verify that the pasted node contains the same meta info.
   const BookmarkNode* pasted = folder->GetChild(0);
   ASSERT_TRUE(pasted->GetMetaInfoMap());
   EXPECT_EQ(2u, pasted->GetMetaInfoMap()->size());
   std::string value;
   EXPECT_TRUE(pasted->GetMetaInfo("somekey", &value));
   EXPECT_EQ("somevalue", value);
   EXPECT_TRUE(pasted->GetMetaInfo("someotherkey", &value));
   EXPECT_EQ("someothervalue", value);
 }
@@ skipping 164 matching lines @@
   model->GetNodesByURL(url, &nodes);
   ASSERT_EQ(1u, nodes.size());
   EXPECT_TRUE(model->bookmark_bar_node()->empty());
   EXPECT_TRUE(model->other_node()->empty());
   EXPECT_TRUE(model->mobile_node()->empty());
   EXPECT_EQ(1, extra_node->child_count());
 }
 
 }  // namespace
 }  // namespace bookmarks