components/bookmarks/browser/bookmark_utils.h - Issue 437423005: Show paste option on right click of bookmark bar if some URL is copied from outside browser or from…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/bookmarks/browser/bookmark_utils.h

Issue 437423005: Show paste option on right click of bookmark bar if some URL is copied from outside browser or from… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit tests Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/bookmarks/browser/bookmark_utils.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UTILS_H_	5 #ifndef COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UTILS_H_

6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UTILS_H_	6 #define COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UTILS_H_

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 132 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
143 bool CanAllBeEditedByUser(BookmarkClient* client,	143 bool CanAllBeEditedByUser(BookmarkClient* client,

144 const std::vector<const BookmarkNode*>& nodes);	144 const std::vector<const BookmarkNode*>& nodes);

145	145

146 // Returns true if \|url\| has a bookmark in the \|model\| that can be edited	146 // Returns true if \|url\| has a bookmark in the \|model\| that can be edited

147 // by the user.	147 // by the user.

148 bool IsBookmarkedByUser(BookmarkModel* model, const GURL& url);	148 bool IsBookmarkedByUser(BookmarkModel* model, const GURL& url);

149	149

150 // Returns the node with \|id\|, or NULL if there is no node with \|id\|.	150 // Returns the node with \|id\|, or NULL if there is no node with \|id\|.

151 const BookmarkNode* GetBookmarkNodeByID(const BookmarkModel* model, int64 id);	151 const BookmarkNode* GetBookmarkNodeByID(const BookmarkModel* model, int64 id);

152	152

	153 // Checks if clipboard contains valid url

	154 bool ClipboardContainsValidUrl(base::string16&);
	sky 2014/08/22 19:40:41 I strongly urge you to read the style guide. Star I strongly urge you to read the style guide. Star with http://www.chromium.org/developers/coding-style and make sure to visit the c++ specific link. . Declaration and definition order should list argument names (and they should be the same). . Decleration and definition order need to be the same. Additionally declaration and definition order must be the same. . Only allowable references are const. If you need an out param, it should be a pointer. Why not make this return a URL? Having said all this, why both with this in the header? It is only used internally. It should be in an anonymous namespace in the .cc.
	155

153 } // namespace bookmarks	156 } // namespace bookmarks

154	157

155 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UTILS_H_	158 #endif // COMPONENTS_BOOKMARKS_BROWSER_BOOKMARK_UTILS_H_

OLD	NEW