Extend some operations to range types.

Extend some operations to range types.

R=rossberg@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=22934

[rossberg, 2014-08-05 14:49:15]

https://codereview.chromium.org/437393005/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/437393005/diff/1/src/types.cc#newcode283
src/types.cc:283: && *this->AsConstant()->Value() ==
*that->AsConstant()->Value();
Check value first, since that is faster.

https://codereview.chromium.org/437393005/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode517
src/types.h:517: static int RangeLub(double min, double max, TypeHandle bound);
Is this defined anywhere?

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode688
src/types.h:688: static bool le(double x, double y) {
These are helpers that shouldn't pollute the public interface. Maybe just make
them static global functions in types.cc?

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode701
src/types.h:701: static int InherentLub(double min, double max) {
Rename/move this to BitsetType::Lub(double, double), since it's also just an
internal helper.

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode704
src/types.h:704: if (min == max) {
eq(min, max)

[neis, 2014-08-06 13:15:01]

https://codereview.chromium.org/437393005/diff/1/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/437393005/diff/1/src/types.cc#newcode283
src/types.cc:283: && *this->AsConstant()->Value() ==
*that->AsConstant()->Value();
On 2014/08/05 14:49:15, rossberg wrote:
> Check value first, since that is faster.

Done.

https://codereview.chromium.org/437393005/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode517
src/types.h:517: static int RangeLub(double min, double max, TypeHandle bound);
On 2014/08/05 14:49:15, rossberg wrote:
> Is this defined anywhere?

Oops, was a leftover.

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode688
src/types.h:688: static bool le(double x, double y) {
On 2014/08/05 14:49:15, rossberg wrote:
> These are helpers that shouldn't pollute the public interface. Maybe just make
> them static global functions in types.cc?

Done.

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode701
src/types.h:701: static int InherentLub(double min, double max) {
On 2014/08/05 14:49:15, rossberg wrote:
> Rename/move this to BitsetType::Lub(double, double), since it's also just an
> internal helper.

Done.

https://codereview.chromium.org/437393005/diff/1/src/types.h#newcode704
src/types.h:704: if (min == max) {
On 2014/08/05 14:49:15, rossberg wrote:
> eq(min, max)

Done.

[rossberg, 2014-08-06 13:27:31]

LGTM, modulo nits

https://codereview.chromium.org/437393005/diff/20001/src/types.cc
File src/types.cc (right):

https://codereview.chromium.org/437393005/diff/20001/src/types.cc#newcode137
src/types.cc:137: DisallowHeapAllocation no_allocation;
Nit: put this first

https://codereview.chromium.org/437393005/diff/20001/src/types.cc#newcode138
src/types.cc:138: if (eq(min, max)) {
Style nit: same line:

  if (eq(min, max)) return ...

https://codereview.chromium.org/437393005/diff/20001/src/types.cc#newcode142
src/types.cc:142: if (le(0, min) || max < 0)
Style nit: same line

https://codereview.chromium.org/437393005/diff/20001/test/cctest/test-types.cc
File test/cctest/test-types.cc (right):

https://codereview.chromium.org/437393005/diff/20001/test/cctest/test-types.c...
test/cctest/test-types.cc:194: static bool le(double x, double y) {
Hint: If you just don't make them static, then you can write T.le() etc below.

[neis, 2014-08-06 13:51:46]

Committed patchset #2 manually as 22934 (presubmit successful).