Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: pkg/analysis_server/test/integration/server_domain_int_test.dart

Issue 437383003: Simplify handling of pathnames in integration tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/server_domain_int_test.dart
diff --git a/pkg/analysis_server/test/integration/server_domain_int_test.dart b/pkg/analysis_server/test/integration/server_domain_int_test.dart
index 90cd81998c3b7c6c9ff986856f152c0ea30d2dfb..99856c7b9525f1b13c220f2d47925dae65bb967f 100644
--- a/pkg/analysis_server/test/integration/server_domain_int_test.dart
+++ b/pkg/analysis_server/test/integration/server_domain_int_test.dart
@@ -49,18 +49,19 @@ class ServerDomainIntegrationTest extends AbstractAnalysisServerIntegrationTest
});
return server_setSubscriptions([]).then((response) {
expect(response, isNull);
- writeFile('test.dart', '''
+ String pathname = sourcePath('test.dart');
+ writeFile(pathname, '''
main() {
var x;
}''');
- setAnalysisRoots(['']);
+ standardAnalysisRoot();
// Analysis should begin, but no server.status notification should be
// received.
return analysisBegun.future.then((_) {
expect(statusReceived, isFalse);
return server_setSubscriptions(['STATUS']).then((_) {
// Tickle test.dart just in case analysis has already completed.
- writeFile('test.dart', '''
+ writeFile(pathname, '''
main() {
var y;
}''');
@@ -112,11 +113,11 @@ main() {
}
}
});
- writeFile('test.dart', '''
+ writeFile(sourcePath('test.dart'), '''
main() {
var x;
}''');
- setAnalysisRoots(['']);
+ standardAnalysisRoot();
expect(analysisBegun.isCompleted, isFalse);
expect(analysisFinished.isCompleted, isFalse);
return analysisBegun.future.then((_) {

Powered by Google App Engine
This is Rietveld 408576698