pkg/analysis_server/test/integration/completion_domain_int_test.dart - Issue 437383003: Simplify handling of pathnames in integration tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/integration/completion_domain_int_test.dart

Issue 437383003: Simplify handling of pathnames in integration tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/test/integration/analysis_error_int_test.dart ('K') | « pkg/analysis_server/test/integration/analysis_error_int_test.dart ('k') | pkg/analysis_server/test/integration/integration_tests.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/integration/completion_domain_int_test.dart

diff --git a/pkg/analysis_server/test/integration/completion_domain_int_test.dart b/pkg/analysis_server/test/integration/completion_domain_int_test.dart

index bfb9238ab166c5b201b4cb319024f0ba31875a1f..4621abee956603168ebeab1798eaf3eac4d32144 100644

--- a/pkg/analysis_server/test/integration/completion_domain_int_test.dart

+++ b/pkg/analysis_server/test/integration/completion_domain_int_test.dart

@@ -17,8 +17,7 @@ class CompletionDomainIntegrationTest extends

AbstractAnalysisServerIntegrationTest {

fail_test_getSuggestions_string_var() {

// See dartbug.com/20188

- String filename = 'test.dart';

- String pathname = normalizePath(filename);

+ String pathname = sourcePath('test.dart');

String text =

r'''

var test = '';

@@ -26,8 +25,8 @@ main() {

test.

}

''';

- writeFile(filename, text);

- setAnalysisRoots(['']);

+ writeFile(pathname, text);

+ standardAnalysisRoot();

return analysisFinished.then((_) {

return server.send(COMPLETION_GET_SUGGESTIONS, {