Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 437383002: Fix jscompile errors. (Closed)

Created:
6 years, 4 months ago by Jamie
Modified:
6 years, 4 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M remoting/webapp/remoting.js View 4 chunks +5 lines, -5 lines 2 comments Download

Messages

Total messages: 11 (0 generated)
Jamie
ptal
6 years, 4 months ago (2014-08-04 23:00:16 UTC) #1
Wez
lgtm https://codereview.chromium.org/437383002/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): https://codereview.chromium.org/437383002/diff/1/remoting/webapp/remoting.js#newcode563 remoting/webapp/remoting.js:563: return navigator.userAgent.match(/\bCrOS\b/) != null; Is this the preferred ...
6 years, 4 months ago (2014-08-05 00:42:27 UTC) #2
Jamie
FYI https://codereview.chromium.org/437383002/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): https://codereview.chromium.org/437383002/diff/1/remoting/webapp/remoting.js#newcode563 remoting/webapp/remoting.js:563: return navigator.userAgent.match(/\bCrOS\b/) != null; On 2014/08/05 00:42:27, Wez ...
6 years, 4 months ago (2014-08-05 01:03:10 UTC) #3
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 4 months ago (2014-08-05 01:03:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/437383002/1
6 years, 4 months ago (2014-08-05 01:07:12 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 05:36:26 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 05:41:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/2772)
6 years, 4 months ago (2014-08-05 05:41:44 UTC) #8
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 4 months ago (2014-08-05 18:56:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/437383002/1
6 years, 4 months ago (2014-08-05 18:57:03 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 20:45:02 UTC) #11
Message was sent while issue was closed. 
Change committed as 287587

Powered by Google App Engine
This is Rietveld 408576698