Issue 437373002: Enable -Wsentinel on linux32, take 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 437373002: Enable -Wsentinel on linux32, take 2. (Closed)

Created:
6 years, 4 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Enable -Wsentinel on linux32, take 2. I checked that gcc also expands NULL to just 0 here, so this no longer seems like a clang bug. BUG=162818 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287479

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/libgtk2ui/gtk2_ui.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/437373002/1

6 years, 4 months ago (2014-08-04 22:46:26 UTC) #4

Message was sent while issue was closed.

Change committed as 287479