Add space to Accept-Encoding header values.

Add space to Accept-Encoding header values.

This is to intended to match the HTTP/2 static table:
http://http2.github.io/http2-spec/compression.html#static.table.definition (entry 16).

BUG=389914
Committed: https://crrev.com/8f00db8b5156e1bc256828d38ead66d91379411a
Cr-Commit-Position: refs/heads/master@{#296551}

[Johnny, 2014-09-03 18:54:15]

Patchset #1 (id:1) has been deleted

[Johnny, 2014-09-03 18:54:21]

Patchset #1 (id:20001) has been deleted

[Johnny, 2014-09-03 18:54:27]

Patchset #1 (id:40001) has been deleted

[Johnny, 2014-09-03 18:56:05]

jgraettinger@chromium.org changed reviewers:
+ rch@chromium.org

[Johnny, 2014-09-03 18:56:05]

If we're concerned about potential fallout from adding a space, we can also
change Chrome's notion of the static table itself (eg, remove the space).

[Ryan Hamilton, 2014-09-04 21:29:28]

On 2014/09/03 18:56:05, Johnny wrote:
> If we're concerned about potential fallout from adding a space, we can also
> change Chrome's notion of the static table itself (eg, remove the space).

Good question! This change LGTM as is, though I wonder how we would notice if
the addition of a space would cause problems? Is there a histogram we might look
at?

[Bence, 2014-09-16 14:38:57]

On 2014/09/04 21:29:28, Ryan Hamilton wrote:
> On 2014/09/03 18:56:05, Johnny wrote:
> > If we're concerned about potential fallout from adding a space, we can also
> > change Chrome's notion of the static table itself (eg, remove the space).
> 
> Good question! This change LGTM as is, though I wonder how we would notice if
> the addition of a space would cause problems? Is there a histogram we might
look
> at?

The only non-test code in this CL is in URLRequestHttpJob::AddExtraHeaders().  I
am afraid that we could only detect problems from user bug reports.  However, I
propose that we go ahead with this change: interop problems are not very likely,
and we gain more by having a header value that is consistent with the HTTP/2
draft.

[Bence, 2014-09-16 14:39:25]

bnc@chromium.org changed reviewers:
+ bengr@chromium.org, bnc@chromium.org

[Bence, 2014-09-16 14:39:25]

bengr@chromium.org: Please review changes in
components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc.
 Thank you.

[Ryan Hamilton, 2014-09-24 15:49:04]

On 2014/09/16 14:39:25, Bence wrote:
> mailto:bengr@chromium.org: Please review changes in
>
components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc.
>  Thank you.

ping

[bengr, 2014-09-24 17:43:07]

On 2014/09/24 15:49:04, Ryan Hamilton wrote:
> On 2014/09/16 14:39:25, Bence wrote:
> > mailto:bengr@chromium.org: Please review changes in
> >
>
components/data_reduction_proxy/browser/data_reduction_proxy_protocol_unittest.cc.
> >  Thank you.
> 
> ping

*data_reduction_proxy*: lgtm

[Bence, 2014-09-24 22:00:07]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2014-09-24 22:01:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/437353004/60001

[commit-bot: I haz the power, 2014-09-24 23:00:13]

Committed patchset #1 (id:60001) as d5e433a43c068084df93bc68fa58dafff24f894b

[commit-bot: I haz the power, 2014-09-24 23:01:04]

Patchset 1 (id:??) landed as
https://crrev.com/8f00db8b5156e1bc256828d38ead66d91379411a
Cr-Commit-Position: refs/heads/master@{#296551}