Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 437353003: Mojo: Ensure the HTML viewer keeps the URLLoader alive long enough to finish (Closed)

Created:
6 years, 4 months ago by Matt Perry
Modified:
6 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Ensure the HTML viewer keeps the URLLoader alive long enough to finish loading the request. This fixes a bug where large pages would only partially load. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M mojo/services/html_viewer/html_viewer.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Matt Perry
6 years, 4 months ago (2014-08-04 22:05:34 UTC) #1
darin (slow to review)
lgtm
6 years, 4 months ago (2014-08-04 23:02:05 UTC) #2
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 4 months ago (2014-08-05 00:34:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/437353003/1
6 years, 4 months ago (2014-08-05 00:35:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 05:02:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-05 06:30:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/1133)
6 years, 4 months ago (2014-08-05 06:30:17 UTC) #7
Matt Perry
The CQ bit was checked by mpcomplete@chromium.org
6 years, 4 months ago (2014-08-05 19:51:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/437353003/1
6 years, 4 months ago (2014-08-05 19:52:48 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 20:44:15 UTC) #10
Message was sent while issue was closed. 
Change committed as 287586

Powered by Google App Engine
This is Rietveld 408576698