Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1119)

Issue 437353002: Fix and reenable checkbox in Polymer page set. (Closed)

Created:
6 years, 4 months ago by wiltzius
Modified:
6 years, 4 months ago
Reviewers:
dtu, nduca, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix and reenable checkbox in Polymer page set. BUG=394756 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tools/perf/page_sets/polymer.py View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wiltzius
6 years, 4 months ago (2014-08-04 21:50:23 UTC) #1
tonyg
lgtm
6 years, 4 months ago (2014-08-05 15:50:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wiltzius@chromium.org/437353002/1
6 years, 4 months ago (2014-08-05 15:51:25 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-05 19:44:11 UTC) #4
commit-bot: I haz the power
Change committed as 287596
6 years, 4 months ago (2014-08-05 21:02:30 UTC) #5
tonyg
A revert of this CL has been created in https://codereview.chromium.org/443793002/ by tonyg@chromium.org. The reason for ...
6 years, 4 months ago (2014-08-06 02:55:47 UTC) #6
wiltzius
6 years, 4 months ago (2014-08-06 18:52:10 UTC) #7
Message was sent while issue was closed.
So it turns out that the radio button's behavior is just unpredictable -- it
doesn't always animate. Daniel from the Polymer team confirms this, and says
that they're fixing it now and will release a new version within a couple days.

So let's leave this patch reverted, as it doesn't address the core issue, and
instead I'll post a new patch in a few days that updates the WPR to the latest
version of the site.

Powered by Google App Engine
This is Rietveld 408576698